-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional review of prop 29 and migration testing #559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff
Codecov Report
@@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 11.58% 12.57% +0.98%
==========================================
Files 8 8
Lines 673 684 +11
==========================================
+ Hits 78 86 +8
+ Misses 586 580 -6
- Partials 9 18 +9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, see comment
} | ||
|
||
// add the balances to the bank genesis | ||
bankGenesis.Balances = append(bankGenesis.Balances, fundRecovery.GetRemainingBalances()...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern here is that a balance uniqueness is not validated on the bank genesis validation
The current prop29 implementation causes errors when migrating the state due two issues.
The JSON parsing of the recovery messages is failing on
main
due to handling of escape priorities.There were also correctness issues in the verification of Ethereum signatures both in terms of correctness. This is also resolved.
This can be tested by downloading the Nov 1 hub snapshot and running.
cosmos/gaia/build/gaiad migrate ~/3924406.cosmoshub-3.json
https://storage.googleapis.com/stargate-genesis/3924406.cosmoshub-3.json
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)